move content of test/simpleTestForGenerator to test/fullTestForGenerator #2779
Conversation
|
The benefit for me is that when we alter the markup of the existing license - especially when we alter |
I believe the CI tests both directories, so any such errors should be caught. I thought of one other issue - we currently take the "canonical" text from the simple test directory. This change was made in response to issue raised that the white space did not precisely match the original license text. If we merge these into a single directory, we would no longer be able to distinguish which text we should use. |
3 participants
Today, almost no one is using the directory
fullTestForGenerator/(license-id)/license/good/for tests and storing more variants of licenses. Including me, because I take some existing license as an example. This new directory has been supported by the publisher for some time.I suggest that we move all files from
test/simpleTestForGenerator/${@}.txttotest/fullTestForGenerator/${@}/license/good/${@}.txt.This is just a draft that moves MIT license and change
test-one-licensescript (it will now pass for MIT but fail for anything else).Let me know what do you think. If you would like it, I will draft a PR that moves all tests. But the final PR will be huge and hard to review. That is why I am making this draft first.